-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile: added make command to run litmus-tests #1543
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Hi @jimil749! Thanks for opening the PR. Good work! Just a few comments:
|
@ishank011 I've updated accordingly! |
Hi @jimil749 thanks for the change. I forgot to add one thing, sorry about that! We now expose two WebDAV endpoints, one which assumes the namespace to be that of the logged-in user ( Lines 452 to 460 in 3b7e1f0
Also, we should add the |
Sure, will do! |
@ishank011, we want a separate make command for both the WebDAV endpoints, right? Maybe |
Yep, I think those should be good. |
@ishank011 I have updated as requested. Though, I am not sure why the tests are failing. 😅 |
Can you rebase? We updated the commit from the owncloud repo used to run the integration tests, so now it should pass. |
Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
LGTM. Nice work! |
Fixes #1106
This PR adds an extra make command to run litmus tests via make.
make litmus-test
executes the tests.Signed-off-by: Jimil Desai jimildesai42@gmail.com